[CLOSED] Fixing bug with restoring checkpoint with two gpus + cleaning CUDA parsing related code

[jeswan]

Issue by pruksmhc
Tuesday Oct 08, 2019 at 14:51 GMT
Originally opened as nyu-mll/jiant#928

---

There was a stray map_location that doesn't currently work with 2 GPUs. I also did some minor cleanup for the cuda parsing code.

---

pruksmhc included the following code: https://github.com/nyu-mll/jiant/pull/928/commits

[jeswan]

Comment by pep8speaks
Tuesday Oct 08, 2019 at 14:56 GMT

---

Hello @pruksmhc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file jiant/__main__.py:

Line 1:24: W291 trailing whitespace

• In the file jiant/utils/utils.py:

Line 39:66: W291 trailing whitespace
Line 40:49: W291 trailing whitespace
Line 41:54: W291 trailing whitespace
Line 42:69: W291 trailing whitespace
Line 45:15: W291 trailing whitespace
Line 47:58: W291 trailing whitespace
Line 48:25: W291 trailing whitespace
Line 59:46: W291 trailing whitespace
Line 63:38: W291 trailing whitespace
Line 68:45: W291 trailing whitespace
Line 406:71: W291 trailing whitespace
Line 407:72: W291 trailing whitespace
Line 408:17: W291 trailing whitespace
Line 409:68: W291 trailing whitespace

You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2019-10-16 11:31:10 UTC