Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small velocity errors in light time correction and stellar aberration #157

Open
ChristopherRabotin opened this issue Jan 8, 2024 · 0 comments
Labels
Kind: bug Something isn't working

Comments

@ChristopherRabotin
Copy link
Member

Bug report

Describe the bug

In the de440s_translation_verif_aberrations test, it's clear that the velocity computation has a difference on the other of a few millimeters per second compared to SPICE. This is surprising given that it's the same algorithm and that the position error is down to machine precision (so 2e-16 km or 0.2 picometers).

The SPICE code indicates that only the position is corrected for, and not the velocity. However, correcting the velocity in the loop brings the error down to 5 mm/s from 7 mm/s.

To Reproduce

Look at test de440s_translation_verif_aberrations in commit 90b6f40.

Expected behavior

Error should be five orders of magnitude less than it currently is: SPK geometric query error is machine precision in position and 5 micrometers per second in velocity.

Platform

Linux

Additional context

Add any other context about the problem here.

@ChristopherRabotin ChristopherRabotin added the Kind: bug Something isn't working label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant