Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Attachment implement CdnAsset #538

Closed
abitofevrything opened this issue Sep 14, 2023 · 0 comments · Fixed by #547
Closed

Make Attachment implement CdnAsset #538

abitofevrything opened this issue Sep 14, 2023 · 0 comments · Fixed by #547
Labels
enhancement New feature or request
Milestone
6.0

Comments

@abitofevrything
Copy link
Member

Is your feature request related to a problem? Please describe.
Nyxx currently doesn't have an in-built way to download Attachments. This is because attachments are not normal CDN assets (different URL format) so they don't work with the base CdnAsset constructor.

Describe the solution you'd like
Implement the CdnAsset interface on Attachment.

Describe alternatives you've considered
Downloading by calling http.get (or client.httpHandler.httpClient.get) on Attachment.url: not a very fluid API.
@abitofevrything abitofevrything added the enhancement New feature or request label Sep 14, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Sep 14, 2023
@abitofevrything abitofevrything mentioned this issue Sep 16, 2023
Merged
7 tasks
@abitofevrything abitofevrything linked a pull request Sep 16, 2023 that will close this issue
Make attachment implement CdnAsset #547
Merged
7 tasks
@l7ssha l7ssha closed this as completed Sep 17, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in nyxx roadmap Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Make attachment implement CdnAsset nyxx-discord/nyxx
2 participants
@l7ssha @abitofevrything