Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warnings raised when the binary is run twice #36

Closed
daubaris opened this issue Dec 8, 2019 · 5 comments
Closed

No warnings raised when the binary is run twice #36

daubaris opened this issue Dec 8, 2019 · 5 comments

Comments

@daubaris
Copy link
Contributor

daubaris commented Dec 8, 2019

cargo-scout does not display errors when the binary is run twice without making any changes to the code.

Steps to reproduce:

  1. Violate clippy::pedantic rule. (e.g., create a 100 LoC function).
  2. Run the program. (It displays the errors correctly)
  3. Run the program again without making any changes.

This results in: No warnings raised by clippy::pedantic in your diff, you're good to go!. I suppose the expected behavior should be that the program should output the warnings again.

@ebroto
Copy link
Contributor

ebroto commented Dec 8, 2019

If I'm not mistaken, this is clippy's fault and has been fixed in nightly. See rust-lang/cargo#7450

I think the change will be available in the next stable version.

@o0Ignition0o
Copy link
Owner

You're correct. Let's leave this issue open until the next stable version is released, so we can make sure it works as expected after the new release :)

@o0Ignition0o
Copy link
Owner

Ok some great news:

I've been able to run cargo +nightly clippy-preview -Z unstable-options --no-default-features -- -W clippy::pedantic on neqo, and it worked and passed --no-default-features as expected, I can't wait for it to get stabilized ! \o/

@o0Ignition0o
Copy link
Owner

@daubaris could you please test again to make sure i can close this one? :)

@daubaris
Copy link
Contributor Author

@o0Ignition0o yeah, I can confirm that it works with --preview flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants