Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mina-signer: use string instead of boolean for compilation option #1149

Closed
nicc opened this issue Oct 3, 2023 · 1 comment · Fixed by #1444
Closed

mina-signer: use string instead of boolean for compilation option #1149

nicc opened this issue Oct 3, 2023 · 1 comment · Fixed by #1444

Comments

@nicc
Copy link
Collaborator

nicc commented Oct 3, 2023

We need to make the mina-signer change that goes with this PR: MinaProtocol/mina#13232

@bkase
Copy link
Member

bkase commented Oct 3, 2023

Context: If we don't expose this in mina-signer, it's not really real. Why is this feature important? It prevents replay attacks from an arbitrary string-labeled network (instead of just two, which isn't enough in a world with projects like zeko)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants