Skip to content
This repository has been archived by the owner on Mar 17, 2020. It is now read-only.

Fix and relax license section of the form #184

Open
4 tasks
nuest opened this issue Mar 21, 2018 · 3 comments
Open
4 tasks

Fix and relax license section of the form #184

nuest opened this issue Mar 21, 2018 · 3 comments

Comments

@nuest
Copy link
Member

nuest commented Mar 21, 2018

The ERC allows arbitrary text in the license properties, see http://o2r.info/erc-spec/spec/#author-and-license-metadata

A new version of o2r-meta can extract the license from an erc.yml: o2r-project/o2r-meta#100

"license": {
"text": "CC0-1.0",
"metadata": "license-md.txt",
"data": "ODbL-1.0",
"code": "Apache-2.0"
},

image

  • make drop-down menus editable fields so users can enter any text
  • fix loading of arbitrary text from the metadata coming from the API
  • remove UI bindings license and instead add an uneditable metadata license fixed to CC0-1.0
  • add short text to the license information, which includes a statement that the metadata license is set by o2r and accepted by the uploading user (it is CC-BY-4.0)
@nuest nuest changed the title Relax license section of the form Update and relax license section of the form Mar 23, 2018
@nuest nuest changed the title Update and relax license section of the form Fix and relax license section of the form Aug 8, 2018
@nuest
Copy link
Member Author

nuest commented Aug 8, 2018

Currently the UI does not load extracted license information:

Snippet from Rmd header:

---
# ...
licenses:
  code: Apache-2.0
  data: "PDDL 1.0"
  text: CC-BY-3.0
---

Excerpt from metadata:

{
"id": "qXHgz",
"metadata": {
"o2r": {
"upload_type": "publication",
"title": "Reproducible Environmental Observations and Analysis",
"temporal": {},
"spatial": {},
"publication_type": "other",
"publication_date": "2018-08-08",
"paperLanguage": [],
"mainfile_candidates": [],
"mainfile": "main.Rmd",
"license": {
"text": "CC-BY-3.0",
"data": "PDDL 1.0",
"code": "Apache-2.0"
},
"keywords": [],
"interaction": [],
"inputfiles": [],

UI screenshot:

image

@MarkusKonk
Copy link

MarkusKonk commented Aug 8, 2018

Dropdown and free text do not work.
It works if the license matches exactly the id of the license.json, i.e. ODC-PDDL-1.0 instead of PDDL 1.0 and CC-BY-4.0 instead of CC-BY-3.0

@nuest
Copy link
Member Author

nuest commented Sep 26, 2018

Then we cannot use a dropdown, or must provide both a free text field and a dropdown?

Solution for editable dropdowns:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants