-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better and more ASCII !! (╯°□°)╯︵ ┻━┻ #105
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Per #204, we don't really have a uniform height/width, so some ASCII can be pretty large. The ASCII probably don't have to all be exactly the same, but we should probably pick a target maximum. For me personally, I use a vertical monitor, so the Lua ASCII takes up so much horizontal space that it messes up printing of languages in multi-language projects. I think 25x25 might be a reasonable target for maximum dimensions, what do you think? Once we pick out max dimensions, I'll write a test to walk over the ASCII and enforce those dimensions. |
Yes, Lua's ascii logo is way too big.
Definitely, setting clear guidelines for new language support is the right way to go. In the same spirit, I created #205 to facilitate the work of new contributors. Once done, I'll add a specific paragraph in the CONTRIBUTING.md called Adding support for a new Language.
The width may be too short, I don't think we have a lot of ascii logos hat fall inside those dimensions. Maybe 25*40.
Yes, having a test we can include in CI would be great. |
Sounds good to me! Just to clarify: you're using the format |
Yes. |
Some of our ascii logos look a bit out of shape...
plz help ಥ_ಥ
Don't hesitate to add more languages, if you feel inspired 💯
The text was updated successfully, but these errors were encountered: