Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mercurial support #1054

Closed
VitalyAnkh opened this issue May 10, 2023 · 8 comments
Closed

mercurial support #1054

VitalyAnkh opened this issue May 10, 2023 · 8 comments
Labels
enhancement New feature or request stale

Comments

@VitalyAnkh
Copy link

Summary 💡

I wish I could see Firefox's repository information via onefetch. Ah! firefox uses mercurial as its vcs.

Motivation 🔦

onefetch should support multiple version control systems besides git, like mercurial, subversion, pijul...

@spenserblack
Copy link
Collaborator

Somewhat related: #860

I think that if we start supporting VCS besides Git, we'll need to consider some sort of refactoring to make fetching repo stats more plugin-like.

Although we can kind of get "universal support" by simply allowing non-Git repos, and just disabling any git stats.

@o2sh
Copy link
Owner

o2sh commented Jul 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Jul 16, 2023
@VitalyAnkh
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

It's a feature request. Why stale since it's not implemented?

@spenserblack spenserblack added the enhancement New feature or request label Jul 26, 2023
@spenserblack
Copy link
Collaborator

@VitalyAnkh This just happens automatically to help clean up issues: https://github.com/o2sh/onefetch/blob/5a632825fc5c2e9a68de6830c54a4626b8371c16/.github/workflows/stale.yml

Now that you've added a comment, IIRC the stale label should get removed on the next scheduled run 🙂

Anyway, adding mercurial support would be a pretty large undertaking for us, and I think we'd want

  • someone who is very familiar with mercurial
  • discussion about how to rearrange the code (detecting VCS instead of assuming git, implementation and organization, etc.)

Before we even start implementing code changes for this.

Step 1 for adding mercurial support will be making Git optional IMO, which is significant enough to deserve its own PR. @o2sh What do you think about making Git optional?

@o2sh
Copy link
Owner

o2sh commented Jul 27, 2023

In addition to making Git optional, it would require a Rust library like gitoxide, but for Mercurial, to parse the necessary repository information, which doesn't exist AFAIK

Unfortunately, Mercurial does not appear to be too popular.

@spenserblack
Copy link
Collaborator

Sounds good to me. With how much we export, it honestly shouldn't be too hard for a Mercurial user to write a separate tool mimicking our behavior.

@o2sh o2sh removed the stale label Jul 30, 2023
@spenserblack
Copy link
Collaborator

FYI if #1152 gets merged then I think it's pretty much guaranteed that we won't support Mercurial. Though adding Mercurial support to gengo does sound fun... 🤔

@o2sh
Copy link
Owner

o2sh commented Oct 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Oct 29, 2023
@o2sh o2sh closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants