show future commit dates without panicking

[MalteT]

Fixes #1306.

Sorry for the long wait! This is the lamest solution I found, the tool will simply display the time as in 5 days. The library time_humanize can already handle this.

Thanks!

[spenserblack]

The simplest solution is often the best. I think saying that the repo is created "in x days/hours/etc." is an elegant and clear way to call out a time traveler.

Is there an emoji combo that can represent a time traveler? 🤔

[o2sh]

Here is a suggestion to simplify the logic and handle commit time before epoch :

fn to_human_time(time: Time) -> String {
    let since_epoch_duration = SystemTime::now()
        .duration_since(SystemTime::UNIX_EPOCH)
        .expect("System time is before the Unix epoch");

    // Calculate the distance from the current time. This handles
    // future dates gracefully and will simply return something like `in 5 minutes`
    let delta_in_seconds = time.seconds - (since_epoch_duration.as_secs() as i64);
    HumanTime::from(delta_in_seconds).to_string()
}

It will also require to update the unit test display_time_before_epoch to avoid an underflow

[MalteT]

The simplest solution is often the best. I think saying that the repo is created "in x days/hours/etc." is an elegant and clear way to call out a time traveler.

Is there an emoji combo that can represent a time traveler? 🤔

🕰️🚀

Maybe those? Did you plan on having something like this?

[spenserblack]

That emoji combo looks good! I'm not saying we have to add those, I was kind of half-joking. But it could be fun as an easter egg.

[o2sh]

I think we can leave out the emoji for now 🤔

Thanks a lot for you contribution @MalteT and @spenserblack for the review 🎉

[MalteT]

I think we can leave out the emoji for now 🤔

Depending on the requirements (is there a config option for emojis? would we always show the with the message?) I would be willing to open a mini PR to add that, @o2sh 🤔

[spenserblack]

is there a config option for emojis?

Nope, because we don't have any emojis in the output yet.