Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Button for jsx-no-target-blank check #126

Open
Joozty opened this issue Mar 24, 2020 · 2 comments
Open

Include Button for jsx-no-target-blank check #126

Joozty opened this issue Mar 24, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Joozty
Copy link
Member

Joozty commented Mar 24, 2020

More info can be found here
@Joozty Joozty changed the title Include DocumentLink for jsx-no-target-blank check Include Button for jsx-no-target-blank check Mar 24, 2020
@Joozty Joozty transferred this issue from oacore/dashboard Mar 24, 2020
@Joozty Joozty added the bug Something isn't working label Mar 24, 2020
@Joozty
Copy link
Member Author

Joozty commented Apr 27, 2020

We cannot configure Button as a link component because we can get false warnings since the button can have any tag passed down. Maybe we should create a new component called Link with hardcoded a element.

@viktor-yakubiv
Copy link
Member

I created #205 as you suggest here. We should adopt Link for the button and disable tag support for the Button. Let's assume that the buttons have a semantic value always and are either pure buttons or links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viktor-yakubiv @Joozty