Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Lerna? #219

Open
viktor-yakubiv opened this issue Jul 16, 2020 · 2 comments
Open

Build with Lerna? #219

viktor-yakubiv opened this issue Jul 16, 2020 · 2 comments

Comments

@viktor-yakubiv
Copy link
Member

I think this repository comes to the stage where we need multiple packages even if we use all of them together. We want here having:

If some external project starts using our style (i doubt it) it may not need to depend on our logo or components, only CSS may be needed. It may be useful even for us, for example for the BSDTAg which is on pure HTML.

It's more for the discusssion. @Joozty what do you think?

@Joozty
Copy link
Member

Joozty commented Jul 16, 2020

Totally agree even it will make maintenance slightly harder. Thanks for bringing it up. 👍

I see the packages slightly differently

@oacore/foundation - sanitize.css, assets (favicons, logo), global.css -deployed under cdn.core.ac.uk
@oacore/templates - templates used for 404, 500 and everything shared between projects (for example cookies notice?)
@oacore/icons - not sure about it but it's probably needed
@oacore/design - everything else

@viktor-yakubiv
Copy link
Member Author

I recently discovered an alternative to Lerna: pnpm.js. I saw, Rollup builds their plugins using pnpm.js. I wonder if this is something worth to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants