Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build from source #284

Open
aadilayub opened this issue May 20, 2024 · 3 comments
Open

Can't build from source #284

aadilayub opened this issue May 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@aadilayub
Copy link

The validate-color package seems to be missing a manifest?

gnome-shell-pano on  master [!?] via  v20.12.2 took 3s 
❯ yarn install
➤ YN0000: · Yarn 4.2.2
➤ YN0000: ┌ Resolution step
➤ YN0014: │ validate-color@https://gitpkg.now.sh/dreamyguy/validate-color/src/validate-color: Only some patterns can be imported from legacy lockfiles (not "https://gitpkg.now.sh/dreamyguy/validate-color/src/validate-color#9e890cb48fed5e22027a67d98750232c4ce780f6")
➤ YN0001: │ Error: validate-color@https://gitpkg.now.sh/dreamyguy/validate-color/src/validate-color: Manifest not found
    at AE.find (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:140:120021)
    at async /var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:559:12938
    at async Object.xZe (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:140:53847)
    at async G2.resolve (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:559:12899)
    at async Pd.resolve (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:141:1451)
    at async Pd.resolve (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:141:1451)
    at async /var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:210:7249
    at async Ky (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:140:53910)
    at async ne (/var/home/aadil/.dev/gnome-shell-pano/.yarn/releases/yarn-4.2.2.cjs:210:7231)
    at async Promise.allSettled (index 55)
➤ YN0000: └ Completed in 0s 576ms
➤ YN0000: · Failed with errors in 0s 602ms

I'm running the latest version of yarn, node v20, and Fedora 40 as the base system.

@aadilayub aadilayub added the bug Something isn't working label May 20, 2024
@Totto16
Copy link
Collaborator

Totto16 commented May 20, 2024

That could be the case, indeed, since we use https://gitpkg.now.sh/dreamyguy/validate-color/src/validate-color instead of the regular npm package, and for good reasons, since the normal one doesn't work with ESM.

However, in the CI and locally we use yarn v1.22.22 (I think it is the version nodes ships with corepack ?!?)

So there it works, I am no expert regarding the ways you can get yarn, and different yarn versions 🤷🏼‍♂️

Maybe we should setup a .zip extension CI build, that generate the needed zip for the extension, so that you don't have to deal with that thing.

That said, it's not possible to replace the used package of validate-color ( I tried it a while ago). So the best thing we can do. Is trying to use the same yarn version. Could you try and using an environment from e.g. nvm and get yarn by typing corepack enable. Does it work then?

@segher86
Copy link

When using yarn set version 1.22.22 it worked for me.

@aadilayub
Copy link
Author

When using yarn set version 1.22.22 it worked for me.

this worked! thanks. Should probably add that to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants