This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-128]Support Decimal in Aggregate/HashJoin #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuechendi
force-pushed
the
wip_decimal_aggr
branch
4 times, most recently
from
e17e9a1 to
99e56aa
Compare
|
|
|
|
|
|
|
|
1. scala hashaggregate remove skip decimal check 2. support unscaledValue 3. support decimal aggregate Signed-off-by: Chendi Xue <chendi.xue@intel.com>
1. Fix HashJoin with decimal as payload issues 1. add decimal support to arrayappender 2. add castStringFromDecimal, castIntegerFromDecimal and castFloatFromDecimal 3. fix castDECIMAL 2. Support Decimal as HashJoin key 3. Support Decimal in BHJ 4. Remove ColumnarExpand decimal check 5. Support MakeDecimal 6. Remove not_in_use codegened ShuffledHashJoin codes and hard config to only do hashcheck HashJoin Signed-off-by: Chendi Xue <chendi.xue@intel.com>
xuechendi
force-pushed
the
wip_decimal_aggr
branch
from
1ea6b00 to
3b93e46
Compare
|
@zhouyuan , rebased |
xuechendi
changed the title
|
|
|
note sure if this relates |
|
@zhouyuan , thanks |
|
|
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
xuechendi
force-pushed
the
wip_decimal_aggr
branch
from
f582846 to
78f63f9
Compare
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
zhouyuan
changed the title
…loat Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
Can you cherry pick this commit? it's a small commit to fix the CI issue |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
@zhouyuan , sorry, I just noticed your email, cherry-picked your commit zhouyuan/native-sql-engine@6ea418a here |
|
|
|
Note: merge this first as several PR are pending on the general framework. TPC-DS results are not correct and will be fixed in later patches |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed TPCDS and TPCH test on decimal non-partition sf500
Q54 and Q58 still saw failure
Fixed: #128