Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS] Fix error when converting buffer to CSRNumericTable #178

Closed
minmingzhu opened this issue Feb 21, 2022 · 0 comments · Fixed by #182
Closed

[ALS] Fix error when converting buffer to CSRNumericTable #178

minmingzhu opened this issue Feb 21, 2022 · 0 comments · Fixed by #182
Labels
bug Something isn't working

Comments

@minmingzhu
Copy link
Collaborator

When converting buffer to CSRNumericTable, If multiple rows without non-zero elements, we only calculated once for rowOffsets Array.

for (i <- 0 until ratingsNum) {
      // Modify row index for each partition (start from 0)
      val row = buffer.getLong(i * RATING_SIZE) - getPartitionOffset(rankId, nFeatures, nBlocks)
      val column = buffer.getLong(i * RATING_SIZE + 8)
      val rating = buffer.getFloat(i * RATING_SIZE + 16)

      values(index) = rating
      // one-based index
      columnIndices(index) = column + 1

      if (row > curRow) {
        curRow = row
        // one-based indexValues
        rowOffsets += index + 1
      }

      index = index + 1
    }
    // one-based row index
    rowOffsets += index + 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants