Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellanous feedback (public comment c201602e00003) #1036

Closed
ralfhandl opened this issue Mar 21, 2024 · 0 comments
Closed

Miscellanous feedback (public comment c201602e00003) #1036

ralfhandl opened this issue Mar 21, 2024 · 0 comments

Comments

@ralfhandl
Copy link
Contributor

Public Review Comment https://lists.oasis-open.org/archives/odata-comment/201602/msg00003.html.

Summary

  • 4.1.1 prose text describing structure of "keys" array doesn't match example 6
    (editor's note: example is correct, prose text is garbled)

  • 4.1.2.5 Nullable Properties, Example 36: "format":"decimal" seems to be missing
    (editor's note: it is missing, should be there according to table in 4.1.2.1)

  • a flag "nullable" would avoid the need to reverse-engineer this information from the type array tailored for validators
    (editor's note: this is currently discussed for Swagger, see add "null value support" in spec? OAI/OpenAPI-Specification#229)

  • 4.5.3.2 Path Expressions: The 2nd list does not contain @odata.navigationPropertyPath
    (editor's note: needs to be added)

  • 4.5.3.6 Expression Apply: mismatch between prose text and example
    (editor's note: needs to be fixed)

  • 4.5.3.10 Expression Not: can this contain annotations?
    (editor's note: yes)

  • 4.5.3.11 Expression Null: Why do annotations not live next to @odata.null, like it is the case for @odata.if etc.? Comment gives two proposals for a simpler syntax
    (editor's note: if edm:Null is an item in a collection it needs to be represented as either just null or as an object. Could make that dependent on the existence of annotations within edm:Null or accept feature loss in JSON representation)

  • 4.5.3.12 Expression UrlRef: The text does not fit to the example, but I think the example is better and should win ;-)
    (editor's note: agreed :-)

Proposal

Apply to next draft revision

Introduce x-nullable keyword

Represent edm:Null just as null if it doesn't contain annotations

Imported from ODATA-911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant