-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline signing: Store public keys in address book #93
Comments
Any ETA for supporting preparation of unsigned transactions? The docs mention "First, generate an unsigned transaction on a networked machine,", but I can not find a way to do it with Oasis CLI (https://docs.oasis.io/general/manage-tokens/cli/account#unsigned). Attempts to modify the config file to create an account without a private key do not work... |
This is already possible which is how I create transactions that need to be signed by the multisig signer. It is just slightly awkward as you need to manually specify the correct nonce as otherwise it will use the nonce of the specified account from your wallet. You can just specify |
How? It does not seem to work?
Or you just need an (any/temporary) account, in order for |
Yes you need any/temporary account for unsigned to work. The account itself is ignored. |
Currently, there is no way to prepare an unsigned transaction using CLI without having the signer's private key. You can only store and use the private key from your wallet and in the address book, only addresses are stored.
I suggest the following: When adding an entry to the address book, one accepted format could also be a public key. In this case the address would be derived from the public key so it is consistent with other address book entries, but the public key would also be stored along. Then, to generate an unsigned transaction with that public key,
--account <some_address_book_entry_pubkey>
can be passed.Alternatively, we could support importing accounts with public keys as accounts instead of address book entries. But this would break the current behavior of the wallet (accounts which you can sign tx with) and address book (accounts which you cannot sign txes with).
The text was updated successfully, but these errors were encountered: