Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons aren't focusable by keyboard after user creates wallet #863

Closed
lukaw3d opened this issue Jun 15, 2022 · 2 comments · Fixed by #864
Closed

Buttons aren't focusable by keyboard after user creates wallet #863

lukaw3d opened this issue Jun 15, 2022 · 2 comments · Fixed by #864
Labels
bug Something isn't working upstream This issue depends on another one upstream ux Usability, user experience etc.

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Jun 15, 2022

Potentially related to #821

  • https://wallet.stg.oasisprotocol.org/create-wallet
  • click "Import my wallet"
  • (when modal opens, existing sidebar buttons get tabindex="-1")
  • complete creating the wallet
  • (when modal closes, old sidebar buttons still have tabindex="-1", but new ones don't)
  • only Wallet, Stake, Close wallet can be focused by tabbing
@lukaw3d lukaw3d added bug Something isn't working ux Usability, user experience etc. labels Jun 15, 2022
@lukaw3d
Copy link
Member Author

lukaw3d commented Jun 16, 2022 •
edited
Loading

Looks like it is caused by <Layer> inside another <Layer>.
(e.g. ResponsiveLayer inside Layer [data-testid="mnemonic-validation"])

Upstream: grommet could show a warning

@lukaw3d
Copy link
Member Author

lukaw3d commented Jun 16, 2022

Related upstream issues:

@lukaw3d lukaw3d mentioned this issue Jun 16, 2022
Merged
@lukaw3d lukaw3d added the upstream This issue depends on another one upstream label Oct 19, 2022
@lukaw3d lukaw3d mentioned this issue Oct 19, 2022
Draft
@lukaw3d lukaw3d mentioned this issue Sep 8, 2023
Open
@lukaw3d lukaw3d mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream This issue depends on another one upstream ux Usability, user experience etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix keyboard accessibility after creating a wallet oasisprotocol/wallet
1 participant
@lukaw3d