Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should skip if no baseline versions available #146

Open
maschad opened this issue Oct 7, 2022 · 2 comments
Open

Should skip if no baseline versions available #146

maschad opened this issue Oct 7, 2022 · 2 comments
Labels
C-enhancement Category: raise the bar on expectations E-mentor Call for participation: Mentorship is available for this issue.

Comments

@maschad
Copy link

maschad commented Oct 7, 2022

Describe your use case

Currently, if one is running this in CI across multiple packages in a workspace, it would be helpful to ignore errors resulting from packages without a baseline version as they could be new crates.

Describe the solution you'd like

Skip checks (akin to major version bumps) if no baseline version is available.

@obi1kenobi
Copy link
Owner

Another use case for this is in https://github.com/hyperium/tonic where there are multiple crates that are intended for testing purposes only and are not published anywhere.

@thomaseizinger
Copy link
Sponsor Contributor

Another use case for this is in hyperium/tonic where there are multiple crates that are intended for testing purposes only and are not published anywhere.

We solve that by not running for crates that have publish set to false:

https://github.com/libp2p/rust-libp2p/blob/e0ab8cd3d577fdfcda7947d27b1df43b0a41d3bd/.github/workflows/ci.yml#L242-L252

@obi1kenobi obi1kenobi added the E-mentor Call for participation: Mentorship is available for this issue. label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

3 participants