Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managers cannot view self-reviews #2657

Open
mkimberlin opened this issue Oct 22, 2024 · 3 comments
Open

Managers cannot view self-reviews #2657

mkimberlin opened this issue Oct 22, 2024 · 3 comments
Labels
bug Something isn't working web-ui

Comments

@mkimberlin
Copy link
Member

Managers or other reviewers should be able to access the self-review of the person they are reviewing. Currently, those are not accessible.

Screen.Recording.2024-10-22.at.1.11.59.PM.mov

Ideally this would work similarly to the current production functionality:

Screen.Recording.2024-10-22.at.1.13.43.PM.mov
@mkimberlin mkimberlin added bug Something isn't working web-ui labels Oct 22, 2024
@ocielliottc
Copy link
Collaborator

@mkimberlin The self review of the reviewee, if submitted, is actually viewable via the link of the reviewer. There will be two tabs in the resulting page, the first is the self-review and the second would be for reviewing the reviewee. The self-review chip never has a link.

@mkimberlin
Copy link
Member Author

@ocielliottc I don't think I saw that behavior. Could you verify that in Dev just to be sure? I'm on a plane. 🤣

@ocielliottc
Copy link
Collaborator

@mkimberlin Verified. I used Test Period 1 and made myself supervisor of Lucky Bear. Impersonated Lucky Bear, did the self-review, and then went back as Crazy Elephant and clicked on my reviewer chip. It took me to the page I previously described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web-ui
Projects
None yet
Development

No branches or pull requests

2 participants