79 collect optimization metrics #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
deemp
force-pushed
the
79-collect-optimization-metrics
branch
from
a7e2920
to
1fa2d31
Compare
fizruk
approved these changes
Feb 14, 2024
aabounegm
reviewed
Feb 14, 2024
Comment on lines
+57
to
+64
| inspect = \case | ||
| Phi -> pure () | ||
| Rho -> pure () | ||
| Sigma -> pure () | ||
| VTX -> pure () | ||
| Label _ -> pure () | ||
| Alpha _ -> pure () | ||
| MetaAttr _ -> pure () |
There was a problem hiding this comment.
couldn't this have simply been
Suggested change
| inspect = \case | |
| Phi -> pure () | |
| Rho -> pure () | |
| Sigma -> pure () | |
| VTX -> pure () | |
| Label _ -> pure () | |
| Alpha _ -> pure () | |
| MetaAttr _ -> pure () | |
| inspect = const $ pure () |
?
There was a problem hiding this comment.
It could, but I wasn't sure it should have been.
There was a problem hiding this comment.
I still don't know what's a dataless attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
PR-Codex overview
Focus of this PR:
This PR focuses on adding metrics collection functionality to the
eo-phi-normalizerpackage.Detailed summary:
MetricsTestSetandMetricsTestdata types to represent metrics tests.Metricsdata type to represent various metrics.collectMetricsfunction to collect metrics from a given program.Inspectabletype class and instances forProgram,Binding,Attribute, andObjectto enable metrics collection.Test.Metrics.Phimodule to include tests for metrics collection.eo-phi-normalizer.cabalto includegeneric-lensandlensas dependencies.eo-phi-normalizer-testto includeTest.Metrics.Phias a test module.Metricsmodule toeo-phi-normalizerpackage.