Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to select html dialog element #514

Open
kristianolsen opened this issue Apr 16, 2024 · 3 comments
Open

How to select html dialog element #514

kristianolsen opened this issue Apr 16, 2024 · 3 comments
Labels

Comments

@kristianolsen
Copy link

inside the storybook element we have a web component that renders a native dialog element. This element is not found using the default chromeSelector. Is there any selector that would find this element?

@techeverri
Copy link
Collaborator

What do you mean by "native dialog"?
If you mean like what you see when you run alert("hello") in the console, then Loki won't be able to screenshot that. In web, Loki can screenshot stuff that can be rendered as DOM elements.

@kristianolsen
Copy link
Author

I mean the html dialog element.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

It can create a dialog that is rendered above all other content. We have elements that wrap a dialog element, but I can not find a selector to use for the screenshot. It seems the dialog is rendered in "another" layer and the content of #storybook-root is therefore in effect an empty element?

@techeverri
Copy link
Collaborator

techeverri commented Jul 19, 2024

Make sure the element has the open attribute. Loki can't screenshot stuff that's hidden.

<dialog open></dialog>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants