Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to support bridgeless mode? #111

Open
dmregister opened this issue Nov 25, 2024 · 3 comments
Open

Are there any plans to support bridgeless mode? #111

dmregister opened this issue Nov 25, 2024 · 3 comments

Comments

@dmregister
Copy link

With the release of RN bridgless mode, it breaks how the native marks are initialized and calculated. Since the RTCBRidge is now a proxy, I dont think the performanceLogger is available and the bridge is not being set, so the NSNotificationCenter is not called.

If you have an idea of a quick way to get this working, im happy to test and put up a PR.

Thanks

@bogrees
Copy link

bogrees commented Dec 4, 2024

I get this crash on Android only with bridgeless mode and the RN new architecture enabled (0.76.3).

Error: Exception in HostFunction: no non-static method "Lcom/oblador/performance/PerformanceModule;.addListener(Ljava/lang/String;)V"

Screenshot 2024-12-04 at 11 51 34 AM

@dmregister
Copy link
Author

you need to patch package to create the method needed for the codegen:

--- a/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
+++ b/node_modules/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java
@@ -219,4 +219,8 @@ public class PerformanceModule extends ReactContextBaseJavaModule implements Tur
         super.onCatalystInstanceDestroy();
         RNPerformance.getInstance().removeListener(this);
     }
+
+    public void addListener(String eventName) {
+
+    }
 }

@bogrees
Copy link

bogrees commented Dec 4, 2024

@dmregister BOOM, that fixed it, thanks a TON!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants