Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cynic-parser tracking issue #808

Open
33 of 55 tasks
obmarg opened this issue Jan 7, 2024 · 0 comments
Open
33 of 55 tasks

cynic-parser tracking issue #808

obmarg opened this issue Jan 7, 2024 · 0 comments

Comments

@obmarg
Copy link
Owner

obmarg commented Jan 7, 2024

Things left to do:

For v0.1.0:

Later:

  • Benchmark
    • Write benchmarks against graphql-parser, async-graphql-parser, apollo-parser
    • Ideally figure out how to benchmark against go, js & other language parsers
    • Publish benchmarks somehow
  • Escape strings in output code fix: escape printed strings in cynic-parser #914
  • Validate the schema roots
  • Generate Debug impls for the reader types
  • Fix the formatting in printing code
  • Parse executable documents
  • Value vs ConstValue (particularly for directives)
  • Update cynic-introspection printing code to use the parser?
  • Iterate on error reports (and test more)
  • Make sure documentation is complete
    • finish a readme
    • at the very least write some lib.rs docs that give an overview of the layout of the crate
  • Special case empty schemas (can have a special error for this instead of whatever the parser says by default)
  • put spans on relevant bits of the AST
  • Clean up the rest of the TODOs in the code
  • Handle escape characters, and string literals generally (iirc I keep the quotes, probably not the best idea) string escaping in cynic-parser #868
  • Pick a structure for the type_system/executable modules and make sure they both use it.
  • Fix the ignored executable parser tests fix: a query formatting issue in parser #947
  • Use IdRange for Value?
  • Figure out how to avoid making every keyword a token of its own (might be possible with latest lalrpop code)
  • Maybe try an inlined small string optimisation
@obmarg obmarg changed the title Add & start using cynic-parser cynic-parser tracking issue Jan 7, 2024
@obmarg obmarg changed the title cynic-parser tracking issue cynic-parser tracking issue Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant