-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lang="en" tag to international version pref labels #10559
Comments
@janelomax |
In CENtree you can set your default language, and your pref labels will be set to that language in the UI. But when English is your default language and @en isn't set in the ontology, it doesn't know which label to choose so a random language is chosen, triggering a flood of users complaining that HPO was showing up in French etc! We've switched to using the English rather than the International version of HPO for now, and longer term we're thinking of adding some logic in CENtree that if a label doesn't have a language tag, to assume that it's in the default language. So we have a work-around, but I still think it would be better to be explicit in the ontology. |
FYI - we could do this just for the hp-international edition - technically this is easy. There are some good arguments to do this just for that specific version, and now harm for us doing it. But note that we are, on OBO level, striding towards a solution that allows for a single "default" language, without the need for language tags. I think that tools should probably support this no matter what. information-artifact-ontology/ontology-metadata#128. We have previously decided to drop language tags for english in HPO here: #10387. @pnrobinson let me know if you think its reasonable to add language tags just for the international edition of HPO, or if you think it causes more churn than value. I am fine either way, 5 min job. |
It seems relatively straightforward to adapt code to assume that English is the default language if no code is supplied. |
In http://purl.obolibrary.org/obo/hp/hp-international.owl the class labels all have explicit lang tags except for the English one e.g.
would it be possible to also have
lang="en" tag
added to the English labels please?The text was updated successfully, but these errors were encountered: