Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicellular organism and organism substance should be disjoint #2421

Open
ddooley opened this issue Apr 15, 2022 · 10 comments · May be fixed by #3151
Open

multicellular organism and organism substance should be disjoint #2421

ddooley opened this issue Apr 15, 2022 · 10 comments · May be fixed by #3151
Assignees

Comments

@ddooley
Copy link

ddooley commented Apr 15, 2022

It came up in discussion with @cmungall that currently there is no disjunction between multicellular organism and organism substance. Since NCBITaxon terms correspond to multicellular organisms, someone can define a 'human milk'[edit] as an axiom like:

'human milk': equivalentTo 'milk and 'Homo Sapiens'

and not get a logical contradiction.

Suggested revision of logical definition

Can we make multicellular organism and organism substance disjoint to trigger unsatisfiability?

@shawntanzk
Copy link
Collaborator

added to uberon agenda, will assign you

@ghost
Copy link

ghost commented Jun 27, 2022

@ddooley, can you advise what is the ultimate goal that you would like to achieve? By making disjoint as you mention above, there is concern this would cause downstream issues. There are concerns with scope related to food (FoodOn) vs anatomy terms (Uberon).

@ddooley
Copy link
Author

ddooley commented Jun 27, 2022

I think it's a basic quality control check - a distinction between a whole, and a proper part. We need to know which references point to whole organisms, and which do not. One should not be confused with the other, so this would trip an error if that happened in UBERON or someone's reuse of it.

However, do things get complicated if, as Chris told me, a reference to an UBERON part, such as heart, logically entails connection to some whole organism in an abstract (dead or alive) sense? I really need an answer to that question - in FoodOn we need to be able to talk about a separated (severed / butchered) heart, one that does not entail a whole connected organism.

@cmungall
Copy link
Member

Let's keep this issues separate

This issue is about the request to make substance and organism disjoint. This is completely reasonable and straightforward. I am surprised we don't have this already, actually.

I don't think there are any concerns. I can't think of any exceptions. there are no organisms made of gas, liquid or other substances created by the body. even an ingested animal ceases at some point to become a multicellular organism and is broken down into substances.

Note that X disjoint with Y simply means there is nothing that instantiates X and Y. There are no further entailments to do with connectedness or parthood.

We already have other issues for the butchered heart use case, but that is completely separate. I think we should grant this request, close this issue, and continue discussing butchered hearts on the other tickets

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Dec 26, 2022
@ddooley
Copy link
Author

ddooley commented Dec 27, 2022

So I should do an UBERON pull request with the disjoint axiom?

@github-actions github-actions bot removed the Stale label Dec 28, 2022
@ddooley
Copy link
Author

ddooley commented Jun 12, 2023

I realize now I don't know how to curate UBERON. Is it the root /uberon.obo file one would edit for disjoints? I tried to edit and save via Protege, but it reported a "multiple def tags not allowed" issue which suggests Uberon team is using some other editor, or text edit?

@anitacaron
Copy link
Collaborator

@ddooley, the edit file is at src/ontology/uberon-edit.obo. But the disjoint file is at src/ontology/components/external-disjoints.obo

Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@ddooley
Copy link
Author

ddooley commented Dec 14, 2023

I've added the axiom to src/ontology/components/external-disjoints.obo and made a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants