Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add process to domain to range of concretizes #650

Closed
wdduncan opened this issue Nov 14, 2022 · 5 comments · Fixed by #738
Closed

add process to domain to range of concretizes #650

wdduncan opened this issue Nov 14, 2022 · 5 comments · Fixed by #738
Assignees
Labels
change request Request to change a relation, property, hierarchy, etc. enhancement

Comments

@wdduncan
Copy link
Collaborator

In BFO-2020 the domain of concretizes at some time is process or 'specifically dependent continuant'. The domain of RO's concretizes should be updated to include process for sake of consistency.

@cmungall
Copy link
Contributor

cmungall commented Jan 3, 2023

I have no objection but this should be taken to the main stakeholders of this relation, which would include OBI. I am not sure who else uses these abstract relations.

@bpeters42
Copy link
Collaborator

Discussed in OBI call 1/9/2023. Relaxing the domain from 'specifically dependent continuant' only to add 'process' should be okay from OBI's point of view.

@wdduncan
Copy link
Collaborator Author

@anitacaron @matentzn I opened a new branch for this issue (branch issue-650). After I made my changes, it reverted the license annotation back to http://purl.org/dc/elements/1.1/license:

-    <!-- http://purl.org/dc/terms/license -->
+    <!-- http://purl.org/dc/elements/1.1/license -->
 
-    <owl:AnnotationProperty rdf:about="http://purl.org/dc/terms/license"/>
+    <owl:AnnotationProperty rdf:about="http://purl.org/dc/elements/1.1/license"/>

Any ideas why?

@anitacaron
Copy link
Collaborator

I commented in the PR.

@cmungall
Copy link
Contributor

cmungall commented Aug 12, 2024

Summarizing from RO call today.

I'm going to rewrite the original ask more precisely: the goal is to relax the domain to change it from SDC to a union SDC or biological process, to be consistent with BFO (http://purl.obolibrary.org/obo/BFO_0000059 -- simply "concretizes" in http://purl.obolibrary.org/obo/bfo/2020/bfo-core.owl)

If we do this, then we should:

  1. Change the text definition to be consistent. Currently it is "A relationship between a specifically dependent continuant and..."
  2. Add an example of usage. We currently have two examples of usages, and both have SDCs (IAs). We need an example of process.
  3. There were various references in the call to a talk, and also to a previous discussion in an OBI call but we should have links here so we can all examine the case

As an aside, we also noticed that we are manually duplicating annotations for inverses. This is not good practice, it violates DRY. @cmungall will look for documentation on existing practice and what we should do here (refer vs automatically propagate in release file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Request to change a relation, property, hierarchy, etc. enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants