Skip to content

Commit 3c6f88d

Browse files
duncte123duncte123
committed
Implement suggestions from review
1 parent 9d0cb13 commit 3c6f88d

File tree

13 files changed

+199
-563
lines changed

13 files changed

+199
-563
lines changed

‎.eslintrc.json‎

Lines changed: 5 additions & 282 deletions
Original file line numberDiff line numberDiff line change
@@ -6,293 +6,16 @@
66
"node": true
77
},
88
"extends": [
9-
"eslint:recommended",
10-
"plugin:@typescript-eslint/recommended"
9+
"xo",
10+
"xo-typescript/space"
1111
],
1212
"parserOptions": {
1313
"ecmaVersion": 12,
1414
"sourceType": "module"
1515
},
1616
"rules": {
17-
"@typescript-eslint/no-explicit-any": "off",
18-
"@typescript-eslint/explicit-module-boundary-types": "off",
19-
"@typescript-eslint/explicit-function-return-type": "error",
20-
"@typescript-eslint/ban-types": "off",
21-
"@typescript-eslint/ban-ts-comment": ["error", {
22-
"ts-ignore": "allow-with-description"
23-
}],
24-
"@typescript-eslint/no-inferrable-types": ["error", {
25-
"ignoreParameters": true,
26-
"ignoreProperties": true
27-
}],
28-
"accessor-pairs": "error",
29-
"array-bracket-newline": "error",
30-
"array-bracket-spacing": [
31-
"error",
32-
"never"
33-
],
34-
"array-callback-return": "error",
35-
"array-element-newline": "off",
36-
"arrow-body-style": "error",
37-
"arrow-parens": [
38-
"error",
39-
"as-needed",
40-
{
41-
"requireForBlockBody": true
42-
}
43-
],
44-
"arrow-spacing": [
45-
"error",
46-
{
47-
"after": true,
48-
"before": true
49-
}
50-
],
51-
"block-scoped-var": "error",
52-
"block-spacing": "error",
53-
"brace-style": "error",
54-
"camelcase": "error",
55-
"capitalized-comments": "off",
56-
"class-methods-use-this": "off",
57-
"comma-dangle": "off",
58-
"comma-spacing": [
59-
"error",
60-
{
61-
"after": true,
62-
"before": false
63-
}
64-
],
65-
"comma-style": [
66-
"error",
67-
"last"
68-
],
69-
"complexity": "error",
70-
"computed-property-spacing": "error",
71-
"consistent-return": "error",
72-
"consistent-this": "error",
73-
"curly": "error",
74-
"default-case": "error",
75-
"default-case-last": "error",
76-
"default-param-last": "error",
77-
"dot-location": [
78-
"error",
79-
"property"
80-
],
81-
"dot-notation": "error",
82-
"eol-last": "error",
83-
"eqeqeq": "error",
84-
"func-call-spacing": "error",
85-
"func-name-matching": "error",
86-
"func-names": "off",
87-
"func-style": [
88-
"error",
89-
"declaration"
90-
],
91-
"function-paren-newline": "error",
92-
"generator-star-spacing": "error",
93-
"grouped-accessor-pairs": "error",
94-
"guard-for-in": "error",
95-
"id-denylist": "error",
96-
"id-length": "off",
97-
"id-match": "error",
98-
"implicit-arrow-linebreak": [
99-
"error",
100-
"beside"
101-
],
102-
"indent": ["error", 2],
103-
"init-declarations": "error",
104-
"jsx-quotes": "error",
105-
"key-spacing": "error",
106-
"keyword-spacing": [
107-
"error",
108-
{
109-
"after": true,
110-
"before": true
111-
}
112-
],
113-
"line-comment-position": "off",
114-
"linebreak-style": [
115-
"error",
116-
"unix"
117-
],
118-
"lines-around-comment": "error",
119-
"lines-between-class-members": ["error", "always", { "exceptAfterSingleLine": true }],
120-
"max-classes-per-file": "error",
121-
"max-depth": "error",
122-
"max-len": "off",
123-
"max-lines": "error",
124-
"max-lines-per-function": "off",
125-
"max-nested-callbacks": "error",
126-
"max-params": "off",
127-
"max-statements": "off",
128-
"max-statements-per-line": "error",
129-
"multiline-comment-style": [
130-
"error",
131-
"separate-lines"
132-
],
133-
"multiline-ternary": "off",
134-
"new-cap": "error",
135-
"new-parens": "error",
136-
"newline-per-chained-call": "error",
137-
"no-alert": "error",
138-
"no-array-constructor": "error",
139-
"no-await-in-loop": "error",
140-
"no-bitwise": "error",
141-
"no-caller": "error",
142-
"no-confusing-arrow": "error",
143-
"no-console": "off",
144-
"no-constructor-return": "error",
145-
"no-continue": "off",
146-
"no-div-regex": "error",
147-
"no-duplicate-imports": "error",
148-
"no-else-return": "error",
149-
"no-empty-function": "error",
150-
"no-eq-null": "error",
151-
"no-eval": "error",
152-
"no-extend-native": "error",
153-
"no-extra-boolean-cast": "off",
154-
"no-extra-bind": "error",
155-
"no-extra-label": "error",
156-
"no-extra-parens": "error",
157-
"no-floating-decimal": "error",
158-
"no-implicit-coercion": "error",
159-
"no-implicit-globals": "error",
160-
"no-implied-eval": "error",
161-
"no-inline-comments": "off",
162-
"no-invalid-this": "off",
163-
"no-iterator": "error",
164-
"no-label-var": "error",
165-
"no-labels": "error",
166-
"no-lone-blocks": "error",
167-
"no-lonely-if": "error",
168-
"no-loop-func": "error",
169-
"no-loss-of-precision": "error",
170-
"no-magic-numbers": "off",
171-
"no-mixed-operators": "off",
172-
"no-multi-assign": "error",
173-
"no-multi-spaces": "error",
174-
"no-multi-str": "error",
175-
"no-multiple-empty-lines": "error",
176-
"no-negated-condition": "error",
177-
"no-nested-ternary": "error",
178-
"no-new": "error",
179-
"no-new-func": "error",
180-
"no-new-object": "error",
181-
"no-new-wrappers": "error",
182-
"no-nonoctal-decimal-escape": "error",
183-
"no-octal-escape": "error",
184-
"no-param-reassign": "error",
185-
"no-plusplus": "off",
186-
"no-promise-executor-return": "error",
187-
"no-proto": "error",
188-
"no-restricted-exports": "error",
189-
"no-restricted-globals": "error",
190-
"no-restricted-imports": "error",
191-
"no-restricted-properties": "error",
192-
"no-restricted-syntax": "error",
193-
"no-return-assign": "error",
194-
"no-return-await": "error",
195-
"no-script-url": "error",
196-
"no-self-compare": "error",
197-
"no-sequences": "error",
198-
"no-shadow": "error",
199-
"no-tabs": "error",
200-
"no-template-curly-in-string": "error",
201-
"no-ternary": "off",
202-
"no-throw-literal": "error",
203-
"no-trailing-spaces": "error",
204-
"no-undef-init": "error",
205-
"no-undefined": "error",
206-
"no-underscore-dangle": "error",
207-
"no-unmodified-loop-condition": "error",
208-
"no-unneeded-ternary": "error",
209-
"no-unreachable-loop": "error",
210-
"no-unsafe-optional-chaining": "error",
211-
"no-unused-expressions": "error",
212-
"no-use-before-define": "off",
213-
"no-useless-backreference": "error",
214-
"no-useless-call": "error",
215-
"no-useless-computed-key": "error",
216-
"no-useless-concat": "error",
217-
"no-useless-constructor": "error",
218-
"no-useless-rename": "error",
219-
"no-useless-return": "error",
220-
"no-var": "error",
221-
"no-void": "error",
222-
"no-warning-comments": "off",
223-
"no-whitespace-before-property": "error",
224-
"nonblock-statement-body-position": "error",
225-
"object-curly-newline": "error",
226-
"object-curly-spacing": ["error", "always"],
227-
"object-property-newline": "error",
228-
"object-shorthand": "error",
229-
"one-var": ["error", "never"],
230-
"one-var-declaration-per-line": "error",
231-
"operator-assignment": "error",
232-
"operator-linebreak": "error",
233-
"padded-blocks": "off",
234-
"padding-line-between-statements": "error",
235-
"prefer-arrow-callback": "error",
236-
"prefer-const": "error",
237-
"prefer-destructuring": "off",
238-
"prefer-exponentiation-operator": "error",
239-
"prefer-named-capture-group": "error",
240-
"prefer-numeric-literals": "error",
241-
"prefer-object-spread": "error",
242-
"prefer-promise-reject-errors": "error",
243-
"prefer-regex-literals": "error",
244-
"prefer-rest-params": "error",
245-
"prefer-spread": "error",
246-
"prefer-template": "error",
247-
"quote-props": "off",
248-
"quotes": [
249-
"error",
250-
"single"
251-
],
252-
"radix": "error",
253-
"require-atomic-updates": "error",
254-
"require-await": "error",
255-
"require-unicode-regexp": "off",
256-
"rest-spread-spacing": "error",
257-
"semi": ["error", "always"],
258-
"semi-spacing": [
259-
"error",
260-
{
261-
"after": true,
262-
"before": false
263-
}
264-
],
265-
"semi-style": [
266-
"error",
267-
"last"
268-
],
269-
"sort-keys": "off",
270-
"sort-vars": "error",
271-
"space-before-blocks": "error",
272-
"space-before-function-paren": "off",
273-
"space-in-parens": [
274-
"error",
275-
"never"
276-
],
277-
"space-infix-ops": "error",
278-
"space-unary-ops": "error",
279-
"spaced-comment": [
280-
"error",
281-
"always"
282-
],
283-
"strict": "error",
284-
"switch-colon-spacing": "error",
285-
"symbol-description": "error",
286-
"template-curly-spacing": "error",
287-
"template-tag-spacing": "error",
288-
"unicode-bom": [
289-
"error",
290-
"never"
291-
],
292-
"vars-on-top": "error",
293-
"wrap-iife": "error",
294-
"wrap-regex": "error",
295-
"yield-star-spacing": "error",
296-
"yoda": "error"
17+
"@typescript-eslint/no-implicit-any-catch": "off",
18+
"@typescript-eslint/no-unsafe-member-access": "off",
19+
"@typescript-eslint/no-unsafe-call": "off"
29720
}
29821
}

‎.github/workflows/build.yml‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [12.x, 14.x, 15.x]
19+
node-version: [12.x, 14.x, 16.x]
2020
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2121

2222
steps:
@@ -25,8 +25,15 @@ jobs:
2525
uses: actions/setup-node@v2
2626
with:
2727
node-version: ${{ matrix.node-version }}
28-
- run: npm install json -g
29-
- run: npm install
28+
- uses: actions/cache@v2
29+
with:
30+
path: ~/.npm
31+
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
32+
restore-keys: |
33+
${{ runner.os }}-node-
34+
# we may need this, not sure
35+
# - run: npm install json -g
36+
- run: npm ci
3037
- run: npm run build
3138
env:
3239
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)