avoid a crash on facet: exclude on a non-faceted mark (#1282)

Fil · web-flow · commit 228f62e551a9 · 2023-02-21T17:41:29.000+01:00
diff --git a/src/plot.js b/src/plot.js
@@ -100,7 +100,7 @@ export function plot(options = {}) {
     for (const mark of marks) {
       if (mark.facet === "exclude") {
         const facetState = facetStateByMark.get(mark);
-        facetState.facetsIndex = facetExclude(facetState.facetsIndex);
+        if (facetState !== undefined) facetState.facetsIndex = facetExclude(facetState.facetsIndex);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ export function plot(options = {}) {`
`100`	`100`	`for (const mark of marks) {`
`101`	`101`	`if (mark.facet === "exclude") {`
`102`	`102`	`const facetState = facetStateByMark.get(mark);`
`103`		`- facetState.facetsIndex = facetExclude(facetState.facetsIndex);`
	`103`	`+ if (facetState !== undefined) facetState.facetsIndex = facetExclude(facetState.facetsIndex);`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`	`}`