given data, don’t defer channels

Author: mbostock

src/marks/axis.js

@@ -545,12 +545,12 @@ function axisMark(mark, k, ariaLabel, data, options, initialize) {
         } else {
           data = scale.domain();
         }
-      }
-      if (k === "y" || k === "x") {
-        facets = [range(data)]; // TODO allow faceted ticks?
-      } else {
-        channels[k] = {scale: k, value: identity};
-        facets = undefined; // computed automatically by plot
+        if (k === "y" || k === "x") {
+          facets = [range(data)];
+        } else {
+          channels[k] = {scale: k, value: identity};
+          facets = undefined; // computed automatically by plot
+        }
       }
       initialize?.call(this, scale, ticks, channels);
       return {
@@ -562,9 +562,13 @@ function axisMark(mark, k, ariaLabel, data, options, initialize) {
       };
     })
   );
-  channels = m.channels;
+  if (data == null) {
+    channels = m.channels;
+    m.channels = {};
+  } else {
+    channels = {};
+  }
   m.ariaLabel = ariaLabel;
-  m.channels = {};
   return m;
 }
 

test/output/aaplCloseDataTicks.svg

@@ -1,7 +1,7 @@
 import * as Plot from "@observablehq/plot";
 import * as d3 from "d3";
 
-export default async function () {
+export async function aaplClose() {
   const AAPL = await d3.csv("data/aapl.csv", d3.autoType);
   return Plot.plot({
     y: {
@@ -14,3 +14,15 @@ export default async function () {
     ]
   });
 }
+
+export async function aaplCloseDataTicks() {
+  const AAPL = await d3.csv("data/aapl.csv", d3.autoType);
+  return Plot.plot({
+    marks: [
+      Plot.axisY(d3.ticks(0, 200, 10), {anchor: "left"}),
+      Plot.areaY(AAPL, {x: "Date", y: "Close", fillOpacity: 0.1}),
+      Plot.lineY(AAPL, {x: "Date", y: "Close"}),
+      Plot.ruleY([0])
+    ]
+  });
+}

test/plots/aapl-close.js

@@ -1,6 +1,5 @@
 export {default as aaplCandlestick} from "./aapl-candlestick.js";
 export {default as aaplChangeVolume} from "./aapl-change-volume.js";
-export {default as aaplClose} from "./aapl-close.js";
 export {default as aaplCloseUntyped} from "./aapl-close-untyped.js";
 export {default as aaplMonthly} from "./aapl-monthly.js";
 export {default as aaplVolume} from "./aapl-volume.js";
@@ -279,6 +278,7 @@ export {default as yearlyRequestsDot} from "./yearly-requests-dot.js";
 export {default as yearlyRequestsLine} from "./yearly-requests-line.js";
 
 export * from "./aapl-bollinger.js";
+export * from "./aapl-close.js";
 export * from "./aapl-fancy-axis.js";
 export * from "./athletes-sample.js";
 export * from "./axis-labels.js";