-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projection fixed-precision option? #1143
Comments
There’s an ancient PR in d3-path for this, I believe. |
Yes, d3/d3-path#12. It's for generic paths, and probably more complicated than we'd want here (we know that we are in screen coordinates and are the last transform in the stream pipeline). |
How is it complicated? I feel like that’s a pretty good existing solution and it’s nice that it would also work for pre-projected and planar geometry. I guess you’re saying we could do it as a point transform and abuse the interface by passing stream.point strings instead of numbers? But I think it would be best to fix this generically in d3-path since other people have wanted this for a while. |
I meant more complicated in the sense that it also has to process arcs. But I also prefer if we can land it. |
I have updated d3/d3-path#12 and it should be ready to go now. Once that’s released as D3 7.8, we can adopt that here and switch to d3.pathFixed instead of d3.path. |
I'm not sure how we could name it, but it would be useful to add an optional quantization/line simplification step at the end of the projection stream pipeline. For instance, the test outputs could be drastically reduced in size. And any SSR map rendered with plot would download faster.
The text was updated successfully, but these errors were encountered: