Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules API spec has non-optional fields #371

Open
saswatamcode opened this issue Sep 6, 2022 · 0 comments
Open

Rules API spec has non-optional fields #371

saswatamcode opened this issue Sep 6, 2022 · 0 comments

Comments

@saswatamcode
Copy link
Member

The Observatorium Rules API spec has some fields set as required for both Alerting and Recording rules (such as for, labels, annotations) which makes it incompatible with upstream Prometheus Rules format. This leads to situations where a valid rules file (checked via promtool check rules) fails to be set via Observatorium.

The Observatorium client spec is already compatible.

A/C:

  • Make Rule API spec compatible with upstream

cc: @jessicalins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant