-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinks on Vagrant running on Windows #28
Comments
The reason why we're symlinking is so we can use our |
That's true, I haven't thought about that. I'm gonna play with it over the weekend. |
I don't think this is an issue only for Windows users, I would expect this to affect anyone using Vagrant or similar. The symlink it creates doesn't use relative paths, so I need to recreate it anyway. I can't tell if this works on Windows (but I suspect it doesn't), but in the Vagrant instance I remove the symlink created and create another one either using |
@g-p-g So your suggestion is change symlinks to use relative paths instead of full paths and that could magically fix the issue? |
@3rd-Eden what do you mean by magically? I explicitly mentioned that it doesn't work for me right now, even when using Vagrant inside Linux or OSX, that is not specific to Windows. The relative path fix the problem I have. |
@g-p-g Yes, sorry about. I read it incorrectly. |
+1 for this issue. |
Sorry for digging up this old issue, but I believe my PR solves this issue: |
I've been using this project for a while but am stuck with v0.0.11. My default OS is Windows (sad, I know), so to make things less weird I use Vagrant for development.
After 248d18c it's not possible to install
pre-commit
because of this:There are ways to enable symlinking from Vagrant on Windows, but they're all hacks and really, really painful.
What do you guys think about supporting copying again (in case symlink creation fails)? If you agree, I can send a PR to support this :)
Thanks!
The text was updated successfully, but these errors were encountered: