Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-way push from Obsidian to CalDAV source #24

Closed
davish opened this issue Feb 23, 2022 · 8 comments
Closed

1-way push from Obsidian to CalDAV source #24

davish opened this issue Feb 23, 2022 · 8 comments
Labels
enhancement New feature or request sync Related to remote sync

Comments

@davish
Copy link
Collaborator

davish commented Feb 23, 2022

From #1, @dbarenholz writes:

Any event you create in obsi plugin is pushed to a calendar in gcal, but changes in gcal aren't propagated back.

@davish davish added the enhancement New feature or request label Feb 23, 2022
@davish davish added the sync Related to remote sync label May 11, 2022
@Gr-Nobel
Copy link

Gr-Nobel commented Nov 1, 2022

Hey i can't create event in obsidian that syncs to the google calendar. I have copied the private ics links and pasted them . I can only view the event but can't create them in obsidian to google calendar

@davish
Copy link
Collaborator Author

davish commented Nov 2, 2022

@Gr-Nobel This feature is not implemented yet, which is why this issue is still open.

@Gr-Nobel
Copy link

Gr-Nobel commented Nov 9, 2022

The plugin got an update is this feature implemented

@davish
Copy link
Collaborator Author

davish commented Nov 9, 2022

No. I will close this issue if this feature is implemented.

@davish davish changed the title 1-way push from Obsidian to Google Calendar 1-way push from Obsidian to CalDAV source Nov 11, 2022
@vigoux
Copy link

vigoux commented Jan 13, 2023

Hey, sorry to be pushy, but do you have any idea of the schedule for that issue to get fixed ?
If needed I am willing to contribute a fix, but I can't guarantee neither that it'll fast, nor well-written...

@vigoux
Copy link

vigoux commented Jan 25, 2023

Looking at the code a little, it seems that the changes are somewhat non-trivial:

  • The EditableCalendar type is really only a shim above NoteCalendar the actual work to make it more generic is actually somewhat big
  • The EditableCalendar API itself is tied to file paths instead of event UIDs.

I am going to attempt to have a look into this and try to open a pull request, but I can't guarantee anything.

@davish
Copy link
Collaborator Author

davish commented Jan 26, 2023

Hi @vigoux, as you observed, the abstractions like EditableCalendar in the models directory are really not very good. To address the problems you've brought up, I'm in the middle of completely rewriting most of the core plugin logic. The first step of that was writing a new cache layer that got merged in #204. I'm working on wiring that up to the four types of calendars currently supported (full notes, daily notes, readonly ICS, and readonly CalDAV) in a local branch that I have not yet pushed up.

I would advise against starting any significant pull request based off of the current master branch that involves the core plugin logic, since the idea is to delete the models folder and rely on other, better separated, classes and abstractions. I won't be accepting PRs that add functionality to the old framework. I will let you know back on this issue when I've posted a PR for the second half of the rewrite.

@vigoux
Copy link

vigoux commented Jan 30, 2023

Hey, thanks for the heads up.
If needed I will gladly test that PR you are mentionning, as this would be a great enabler on my side.

Thanks again for your time.

@obsidian-community obsidian-community locked and limited conversation to collaborators Apr 7, 2023
@davish davish converted this issue into discussion #346 Apr 7, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request sync Related to remote sync
Projects
None yet
Development

No branches or pull requests

3 participants