Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Allow support for Github Enterprise #98

Closed
2 tasks done
vswraith opened this issue Jan 31, 2023 · 5 comments
Closed
2 tasks done

[FR]: Allow support for Github Enterprise #98

vswraith opened this issue Jan 31, 2023 · 5 comments
Assignees
Labels
✨ Enhancement New feature or request

Comments

@vswraith
Copy link

Issue validation

Workflow

Obsidian plugin 💠

Is your feature related to a problem ?

We need an option to allow publishing to GitHub Enterprise repos

What solution do you want to see ?

Allow user to enter Github enterprise repo url.

Describe the alternative you've considered

No response

OS

MacOS, Linux

Anything else?

No response

@vswraith vswraith added the ✨ Enhancement New feature or request label Jan 31, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Jan 31, 2023

What is a github enterprise repo ? What is different from a normal repo ?

@vswraith
Copy link
Author

vswraith commented Feb 2, 2023

Its effectively github but hosted on an internal server(https://github.com/enterprise). So basically if we have an option in the plugin to give the full url of the repo,it should be enough as right now there is no way to give the git repo url

@Mara-Li
Copy link
Member

Mara-Li commented Feb 2, 2023

Okay, I think I can do something, but I need confirmation!
https://docs.github.com/en/enterprise-server@3.7/rest/guides/scripting-with-the-rest-api-and-javascript
Normally, I just need to changes this https://github.com/ObsidianPublisher/obsidian-github-publisher/blob/504418dde38cfa6e7d1c1ec82d423dfa72303229/plugin/main.ts#L41
with adding an baseURL things :

import { Octokit } from "octokit";

const octokit = new Octokit({ 
  baseUrl: "http(s)://HOSTNAME/api/v3",
  auth: 'YOUR-TOKEN',
});

Is the HOSTNAME the same as your GitHub repo name, or it's other things?

At last, it doesn't seem difficult at all to introduce this!

Just a question: Do you use Obsidian for works ? Do you have an Obsidian License if so ?

@Mara-Li Mara-Li self-assigned this Feb 2, 2023
Mara-Li added a commit that referenced this issue Feb 2, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Feb 2, 2023

Hey!
Could you please try the new beta : 4.12.0-5 ?

@vswraith
Copy link
Author

vswraith commented Feb 3, 2023

Thanks, will give it a try.
I have bought the license so can use it for work as Confluence is too painful to use :)

@vswraith vswraith closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants