-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filenames are urlencoded when import from Notion #303
Comments
Would it be possible for you to provide us with a Notion export zip file that we could use to help test and resolve this issue? Thank you! |
@tgrosinger I can not share the export zip since it contains confidential info. Here is the screenshot from Notion exported html: |
Hi @and7ey, was If so, then this means Notion is responsible for encoding the filename on export, and perhaps we can decode this with Importer... |
The decoded filename looks Ok |
I just tested this in my Notion workspace and can confirm the same thing happens when exporting. Will have a look in decoding back into the original characters — the challenge will be updating this across the Vault for all references to the file. |
It's actually even worse than that; this is the component of the
and compare this to the URL-encoded filename:
They're not the same — the
This leads me to believe this is actually a bug with Notion's export utility: the encoding should only be required for the |
What if we follow the MS Excel approach when importing CSV file - it shows the file content, suggests the encoding and asks if user would like to change it. What if we do the same? Single encoding, double encoding? |
I think it's probably simpler to default to decoding the filenames — we know how Notion encodes them so we can just apply the same decoder across the board. For filenames that aren't encoded in the first place, applying the URL decoder should leave them unmodified anyway — although in theory someone could intentionally have |
Here is an example how some file names are imported:
Here is an example of full filename:
%D0%A0%D1%83%D0%BA%D0%BE%D0%B2%D0%BE%D0%B4%D1%81%D1%82%D0%B2%D0%BE_%D0%BF%D0%BE_%D0%BF%D0%BE%D0%B4%D0%BA%D0%BB%D1%8E%D1%87%D0%B5%D0%BD%D0%B8%D1%8E_DK103M(W)(-4G)
The text was updated successfully, but these errors were encountered: