Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] add evaluate method to mis.report #123

Merged
merged 1 commit into from
Oct 14, 2018
Merged

[IMP] add evaluate method to mis.report #123

merged 1 commit into from
Oct 14, 2018

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Sep 10, 2018

Add new simplified method to evaluate a mis report over a time period.

robinkeunen
robinkeunen approved these changes Oct 1, 2018
View reviewed changes
Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me and I tested locally but I didn't dig deep into the underlying logic (ie prepare_kpi_matrix and declare_and_compute_period)

@sbidoul sbidoul force-pushed the 10.0-evaluate branch 2 times, most recently from 4b23a4c to 0aa9a8d Compare October 2, 2018 09:45
@sbidoul sbidoul merged commit f5de7da into OCA:10.0 Oct 14, 2018
@sbidoul sbidoul deleted the 10.0-evaluate branch October 14, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwillig benwillig benwillig approved these changes

@robinkeunen robinkeunen robinkeunen approved these changes

Assignees
No one assigned
Labels
10.0 enhancement needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbidoul @robinkeunen @benwillig