Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sections to Level access control on teacher dashboard #2385

Closed
4 tasks
lauracumming opened this issue Nov 29, 2024 · 12 comments · Fixed by #2386 or ocadotechnology/rapid-router#1751
Closed
4 tasks
Assignees

Comments

@lauracumming
Copy link

Task Description

Add the final episodes to PD

Acceptance Criteria

  • Levels appear in dashboard
  • Access checked

Analytics Requirements

  • GA

Copywrite Requirements

  • Same as levels page
    Image
@SKairinos
Copy link
Collaborator

Actually, this seems to be correct/the intended behaviour because the new episodes we added don't have levels. Notice how the "String Manipulation" and "Lists" episodes are also not in the level-control.
Image

Shall I close this ticket?

@lauracumming
Copy link
Author

oooooo

@lauracumming
Copy link
Author

Let me have a look... 👀

@lauracumming
Copy link
Author

Looks like we still need to restrict the access, otherwise the students can start the worksheet /look ahead

@SKairinos
Copy link
Collaborator

Unfortunately, the way the code is currently written, there's no way to block access to an episode. The way it works is an episode is implicitly blocked when all it's levels have been blocked. However, because the new episodes don't have levels (only worksheets), the logic will need to be re-written. Will start on it now but this will increase the size of the task.

@SKairinos
Copy link
Collaborator

SKairinos commented Dec 2, 2024

Required code changes:

  • Create new DB model to track episode worksheets
  • Allow enabling/disabling individual worksheets
  • Worksheets need to track their place in an episode (before/after level X)
  • Episode's should not be rendered if all levels AND all worksheets are blocked.

@SKairinos
Copy link
Collaborator

ready to test this on staging

@lauracumming
Copy link
Author

Will look now ... 👀

@lauracumming
Copy link
Author

lauracumming commented Dec 4, 2024

Spotted an error on the labelling - should say part 2, not part 1 at bottom of this section. We can create new ticket for this and the section arrows to be added.

Image

@lauracumming
Copy link
Author

Couple of things:

  1. The top blue section doesn't retain selection when saved, it remains open for use.
  2. When the teacher goes back to the additional class settings, the previous choice of accessible sections isn't retained and so they have to remember what was ticked/unticked previously.

@SKairinos
Copy link
Collaborator

Fixed the 1st issue.

Re: the 2nd issue, the levels are only locked for students of that class
Image

@lauracumming
Copy link
Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants