-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove build dependencies #1148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)
setup.py, line 28 at r1 (raw file):
"django-foundation-statics==5.4.7", "django-pipeline==1.6.14", # Setting this to 1.6.14 as 1.7 causes issue with compiling SCSS files "django-autoconfig",
We still need this here I think (rapid-router needs django-autoconfig to run)
.github/workflows/ci.yml, line 29 at r1 (raw file):
pip install pytest-cov pipenv install --dev --system pip install -U git+https://github.com/ocadotechnology/codeforlife-portal.git#egg=codeforlife-portal #TODO: Remove as part of #688
This should work without the full Git URL now right? As in pip install -U codeforlife-portal
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 91.28% 91.31% +0.03%
==========================================
Files 111 111
Lines 6197 6197
==========================================
+ Hits 5657 5659 +2
+ Misses 540 538 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)
setup.py, line 28 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
We still need this here I think (rapid-router needs django-autoconfig to run)
Done.
.github/workflows/ci.yml, line 29 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
This should work without the full Git URL now right? As in
pip install -U codeforlife-portal
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is