Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove build dependencies #1148

Merged
merged 3 commits into from
Dec 21, 2020
Merged

fix: Remove build dependencies #1148

merged 3 commits into from
Dec 21, 2020

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Dec 21, 2020

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Dec 21, 2020
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)


setup.py, line 28 at r1 (raw file):

        "django-foundation-statics==5.4.7",
        "django-pipeline==1.6.14",  # Setting this to 1.6.14 as 1.7 causes issue with compiling SCSS files
        "django-autoconfig",

We still need this here I think (rapid-router needs django-autoconfig to run)


.github/workflows/ci.yml, line 29 at r1 (raw file):

          pip install pytest-cov
          pipenv install --dev --system
          pip install -U git+https://github.com/ocadotechnology/codeforlife-portal.git#egg=codeforlife-portal #TODO: Remove as part of #688

This should work without the full Git URL now right? As in pip install -U codeforlife-portal

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1148 (bcb169a) into master (fdcd967) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   91.28%   91.31%   +0.03%     
==========================================
  Files         111      111              
  Lines        6197     6197              
==========================================
+ Hits         5657     5659       +2     
+ Misses        540      538       -2     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
game/random_road.py 91.00% <0.00%> (ø)
game/tests/test_random_road.py 99.11% <0.00%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcd967...bcb169a. Read the comment docs.

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @razvan-pro)


setup.py, line 28 at r1 (raw file):

Previously, razvan-pro (Razvan Mahu) wrote…

We still need this here I think (rapid-router needs django-autoconfig to run)

Done.


.github/workflows/ci.yml, line 29 at r1 (raw file):

Previously, razvan-pro (Razvan Mahu) wrote…

This should work without the full Git URL now right? As in pip install -U codeforlife-portal

Done.

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faucomte97 faucomte97 changed the title build: Remove build dependencies fix: Remove build dependencies Dec 21, 2020
@faucomte97 faucomte97 merged commit b533301 into master Dec 21, 2020
@faucomte97 faucomte97 deleted the remove_build_dependencies branch December 21, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants