feat: check cookie consent when muting game

[razvan-pro]

Description

When muting the game, the cookie should only be set if the user gave consent for functional cookies. Muting the game should still work, but the status won't be saved on page reload or other levels if the cookie is not set.

How Has This Been Tested?

1. Change cookie settings to allow functional cookies, then mute the game and either refresh the page or go to another level. The game should still be muted.
2. Change cookie settings to disallow functional cookies, then mute the game and either refresh the page or go to another level. The game should not be muted anymore as the status has not been saved. However, toggling the mute button should work while on the page (until reloading).

Checklist:

• Game mute status should be saved if the user gives functional cookies consent.
• Game mute status should not be saved otherwise.
• Game mute feature should still work in any case.

---

This change is 

[codecov]

Codecov Report

Merging #1157 (c80b385) into master (c041935) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   91.31%   91.30%   -0.02%     
==========================================
  Files         111      111              
  Lines        6197     6197              
==========================================
- Hits         5659     5658       -1     
- Misses        538      539       +1     

Impacted Files	Coverage Δ
game/random_road.py	90.64% <0.00%> (-0.36%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c041935...c80b385. Read the comment docs.

[faucomte97]

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

[faucomte97]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)

---

game/static/game/js/game.js, line 489 at r1 (raw file):

  } else {
    ocargo.sound.unmute()
    if (hasFunctionalCookiesConsent()) {

Since CodeClimate is complaining that this bit is duplicate code with the bit above and that the function's cyclomatic complexity is too high, maybe you could refactor this into a separate function and pass in the true/false argument?

[faucomte97]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

[razvan-pro]

Reviewable status: complete! all files reviewed, all discussions resolved

---

game/static/game/js/game.js, line 489 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Since CodeClimate is complaining that this bit is duplicate code with the bit above and that the function's cyclomatic complexity is too high, maybe you could refactor this into a separate function and pass in the true/false argument?

👍

[faucomte97]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)