Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update jquery.cookie to js.cookie #1177

Merged
merged 2 commits into from
May 5, 2021
Merged

fix: update jquery.cookie to js.cookie #1177

merged 2 commits into from
May 5, 2021

Conversation

dionizh
Copy link
Contributor

@dionizh dionizh commented May 4, 2021

Testing it by playing RR and keeping eye on the console for any issue. Let me know if there's a better way to test this.


This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1177 (a6274ac) into master (b3fdd65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         111      111           
  Lines        6200     6200           
=======================================
  Hits         5661     5661           
  Misses        539      539           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fdd65...a6274ac. Read the comment docs.

@dionizh dionizh merged commit 3679491 into master May 5, 2021
@dionizh dionizh deleted the jscookieupdate branch May 5, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants