-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add hint text for RR lv 80 onwards #1203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 91.33% 91.37% +0.03%
==========================================
Files 111 111
Lines 6234 6236 +2
==========================================
+ Hits 5694 5698 +4
+ Misses 540 538 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dionizh)
game/messages.py, line 2079 at r1 (raw file):
PYTHONHINT = ( "<br /><br />Check our documentation site, to see " "<a href='https://docs.codeforlife.education/rapid-router/python-commands' target='_blank'>the full list of the commands</a>."
the full list of commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dionizh)
game/messages.py, line 1863 at r1 (raw file):
# --- Introduction to Python levels --- INTROHINT = (
Minor, maybe INTRO_HINT
would be better? Same for PYTHON_HINT
below, not a strong suggestion though 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/messages.py, line 1863 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Minor, maybe
INTRO_HINT
would be better? Same forPYTHON_HINT
below, not a strong suggestion though 🙂
Done.
game/messages.py, line 2079 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
the full list of commands
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dionizh)
This change is