Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hint text for RR lv 80 onwards #1203

Merged
merged 3 commits into from
Jun 25, 2021
Merged

fix: add hint text for RR lv 80 onwards #1203

merged 3 commits into from
Jun 25, 2021

Conversation

dionizh
Copy link
Contributor

@dionizh dionizh commented Jun 25, 2021

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #1203 (39c9fb9) into master (2350055) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
+ Coverage   91.33%   91.37%   +0.03%     
==========================================
  Files         111      111              
  Lines        6234     6236       +2     
==========================================
+ Hits         5694     5698       +4     
+ Misses        540      538       -2     
Impacted Files Coverage Δ
game/messages.py 97.54% <100.00%> (+<0.01%) ⬆️
game/random_road.py 91.36% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2350055...39c9fb9. Read the comment docs.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dionizh)


game/messages.py, line 2079 at r1 (raw file):

PYTHONHINT = (
    "<br /><br />Check our documentation site, to see "
    "<a href='https://docs.codeforlife.education/rapid-router/python-commands' target='_blank'>the full list of the commands</a>."

the full list of commands

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dionizh)


game/messages.py, line 1863 at r1 (raw file):

# --- Introduction to Python levels ---

INTROHINT = (

Minor, maybe INTRO_HINT would be better? Same for PYTHON_HINT below, not a strong suggestion though 🙂

Copy link
Contributor Author

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/messages.py, line 1863 at r1 (raw file):

Previously, razvan-pro (Razvan Mahu) wrote…

Minor, maybe INTRO_HINT would be better? Same for PYTHON_HINT below, not a strong suggestion though 🙂

Done.


game/messages.py, line 2079 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

the full list of commands

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

@dionizh dionizh merged commit 0c4e944 into master Jun 25, 2021
@dionizh dionizh deleted the hintupdates branch June 25, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants