fix: deleting workspace now makes the name disappear

[sebp999]

Description

Fixes #1014: alter static/saving/game/saving.js to make the level name disappear after successful delete

How Has This Been Tested?

Manual test (Chrome v95) and ran unit tests

Screenshots (if appropriate):

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• [ √ ] I have linked this PR to a Zenhub Issue.

---

This change is 

[razvan-pro]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sebp999)

---

game/static/game/js/saving.js, line 95 at r1 (raw file):

            },
            success: function (json) {
                $("#loadWorkspaceTable > tr[selected]").remove();

Hi @sebp999! This fixes it when there are multiple rows in the table, but when it's just one, I see the table will look like this until refreshed:

Also, I think the workspace remains selected after deleting it and the buttons are active as well, so clicking on "Delete" again will trigger an error - this happens when there are multiple rows too.

Can you have a look at fixing those as well, please? (From a quick look, loadInWorkspaces on line 970 in game.js seems to be useful - maybe we can call this function with changed workspaces to fix the one-row case and active buttons too? Otherwise, just copying some bits from it will do (or better even, extracting them into a separate function))

[sebp999]

Hi @razvan-pro thanks for the pointer. I made another change which fixes it. (Turns out there was an undefined this). Have a look.

[razvan-pro]

Yep, this works, thanks @sebp999!

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sebp999)

[codecov]

Codecov Report

Merging #1243 (1f2a5f9) into master (9a4c2e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          99       99           
  Lines        5296     5296           
=======================================
  Hits         4847     4847           
  Misses        449      449           

Impacted Files	Coverage Δ
game/random_road.py	91.00% <0.00%> (ø)