Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with deleted students appearing #1256

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

dionizh
Copy link
Contributor

@dionizh dionizh commented Nov 22, 2021

This change is Reviewable

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #1256 (8d4497b) into master (edc7fa9) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          98       98           
  Lines        5354     5354           
=======================================
  Hits         4830     4830           
  Misses        524      524           
Impacted Files Coverage Δ
game/views/level_editor.py 65.80% <50.00%> (ø)
game/views/level_moderation.py 36.66% <50.00%> (ø)
game/views/scoreboard.py 86.66% <100.00%> (ø)

@dionizh dionizh merged commit 38fc3ca into master Nov 22, 2021
@dionizh dionizh deleted the deletedstudentfix branch November 22, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants