-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add variables, maths and comparison blocks #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @razvan-pro)
game/migrations/0074_add_new_blocks.py, line 9 at r1 (raw file):
block2 = Block(type="variables_numeric_set") block3 = Block(type="variables_increment")
We might remove these 2 🙂
game/static/game/js/blocklyCompiler.js, line 161 at r1 (raw file):
}; ocargo.BlocklyCompiler.prototype.createVariableNumeric = function (block) {
This and the below are probably to be removed as well (and all references)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 2 files at r7, 54 of 56 files at r8, 1 of 3 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 1 of 1 files at r13, 2 of 2 files at r14, 3 of 3 files at r15, all commit messages.
Dismissed @razvan-pro from 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r16, 1 of 1 files at r17, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
- Coverage 91.87% 91.53% -0.35%
==========================================
Files 107 108 +1
Lines 5636 5657 +21
==========================================
Hits 5178 5178
- Misses 458 479 +21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
This change is