Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variables, maths and comparison blocks #1270

Merged
merged 50 commits into from
Oct 30, 2023
Merged

Conversation

razvan-pro
Copy link
Collaborator

@razvan-pro razvan-pro commented Dec 15, 2021

This change is Reviewable

@razvan-pro razvan-pro self-assigned this Dec 15, 2021
Copy link
Collaborator Author

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @razvan-pro)


game/migrations/0074_add_new_blocks.py, line 9 at r1 (raw file):

    block2 = Block(type="variables_numeric_set")
    block3 = Block(type="variables_increment")

We might remove these 2 🙂


game/static/game/js/blocklyCompiler.js, line 161 at r1 (raw file):

};

ocargo.BlocklyCompiler.prototype.createVariableNumeric = function (block) {

This and the below are probably to be removed as well (and all references)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r4, 1 of 2 files at r7, 54 of 56 files at r8, 1 of 3 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 1 of 1 files at r13, 2 of 2 files at r14, 3 of 3 files at r15, all commit messages.
Dismissed @razvan-pro from 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r16, 1 of 1 files at r17, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@faucomte97 faucomte97 marked this pull request as ready for review October 27, 2023 15:37
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1270 (b18dd9c) into master (daec981) will decrease coverage by 0.35%.
Report is 1 commits behind head on master.
The diff coverage is 63.93%.

❗ Current head b18dd9c differs from pull request most recent head c496ef0. Consider uploading reports for the commit c496ef0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   91.87%   91.53%   -0.35%     
==========================================
  Files         107      108       +1     
  Lines        5636     5657      +21     
==========================================
  Hits         5178     5178              
- Misses        458      479      +21     
Files Coverage Δ
game/migrations/0083_alter_block_block_type.py 100.00% <100.00%> (ø)
game/models.py 95.45% <ø> (ø)
game/views/level.py 73.75% <84.61%> (+0.73%) ⬆️
...rations/0079_populate_block_type_add_cow_blocks.py 78.26% <16.66%> (-21.74%) ⬇️
game/migrations/0084_add_new_blocks.py 60.52% <60.52%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r18, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@faucomte97 faucomte97 merged commit 4d424eb into master Oct 30, 2023
3 checks passed
@faucomte97 faucomte97 deleted the new-blocks branch October 30, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants