fix: Scoreboard select all boxes, dropdown styles and text spacing #1277
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/static/game/css/scoreboard.css, line 93 at r1 (raw file):
a.next { padding-left: 10px; }
Minor, but I think this is better as margin. (So say if there's a background colour it would look right.)
game/templates/game/scoreboard.html, line 62 at r1 (raw file):
<div class="col-sm-4"> <div class="dropdown"> <button class="button--secondary button--secondary--dark button--dropdown" type="button" data-toggle="dropdown" aria-expanded="false">
What does this fix?
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @dionizh)
game/static/game/css/scoreboard.css, line 93 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Minor, but I think this is better as margin. (So say if there's a background colour it would look right.)
Done.
game/templates/game/scoreboard.html, line 62 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
What does this fix?
It fixes the bug where the dropdown gets opened if the user presses enter in the search box.
https://stackoverflow.com/questions/23668996/bootstrap-dropdown-always-get-focused-when-pressing-enter-key-in-form/39902207
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 90.63% 90.61% -0.02%
==========================================
Files 98 98
Lines 5318 5318
==========================================
- Hits 4820 4819 -1
- Misses 498 499 +1
|
Fixes bugs rows 39, 40 and 41 in bugs spreadsheet and also part of bug row 32
This change is