-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set cursor to pointer on scoreboard dropdowns #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/static/game/css/scoreboard.css, line 63 at r2 (raw file):
#scoreboardForm .button--regular, #scoreboardForm label { cursor: pointer;
Hm, we may need a separate fix for this, but I found that if you click on the button, but outside the label (e.g. on the space above the text), it doesn't select the checkbox. Maybe we should not make the cursor pointer on the button until we fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @razvan-pro)
game/static/game/css/scoreboard.css, line 63 at r2 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Hm, we may need a separate fix for this, but I found that if you click on the button, but outside the label (e.g. on the space above the text), it doesn't select the checkbox. Maybe we should not make the cursor pointer on the button until we fix that?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 90.65% 90.67% +0.01%
==========================================
Files 98 98
Lines 5317 5317
==========================================
+ Hits 4820 4821 +1
+ Misses 497 496 -1
|
This change is