feat: Remove local storage #1305
Conversation
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/end_to_end_tests/test_localstorage.py, line 30 at r1 (raw file):
) def test_nothing_in_localstorage(self):
If we're not storing anything anymore I don't think we need to test it? Moving forward I think it's a bit weird to see a test for something that doesn't happen.
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @dionizh)
game/end_to_end_tests/test_localstorage.py, line 30 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
If we're not storing anything anymore I don't think we need to test it? Moving forward I think it's a bit weird to see a test for something that doesn't happen.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
- Coverage 91.72% 91.61% -0.11%
==========================================
Files 98 97 -1
Lines 5294 5262 -32
==========================================
- Hits 4856 4821 -35
- Misses 438 441 +3
|
This change is