fix: Improve level 74 solution #1308
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/migrations/0074_level_74_solution.py, line 8 at r1 (raw file):
Level = apps.get_model("game", "Level") level74 = Level.objects.get(name="74", default=1) level74.model_solution = "[14]"
Not sure what this is, but I believe you 😄
game/migrations/0074_level_74_solution.py, line 21 at r1 (raw file):
class Migration(migrations.Migration): dependencies = [("game", "0073_level_75_solution")] operations = [migrations.RunPython(update_level, reverse_code=dummy_reverse)]
You can use migrations.RunPython.noop for reverse_code, then you won't need the dummy_reverse method 🙂
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @razvan-pro)
game/migrations/0074_level_74_solution.py, line 21 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
You can use
migrations.RunPython.noopforreverse_code, then you won't need thedummy_reversemethod 🙂
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
- Coverage 91.63% 91.63% -0.01%
==========================================
Files 97 98 +1
Lines 5262 5271 +9
==========================================
+ Hits 4822 4830 +8
- Misses 440 441 +1
|
This change is