Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show default data on student scoreboard #1315

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Mar 7, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Mar 7, 2022
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/views/scoreboard.py, line 205 at r1 (raw file):

    all_episode_ids = list(range(1, 12))

    if user.is_independent_student():

Can we fix is_independent_student() too, please? It seems to be missing a .profile

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)


game/views/scoreboard.py, line 205 at r1 (raw file):

Previously, razvan-pro (Razvan Mahu) wrote…

Can we fix is_independent_student() too, please? It seems to be missing a .profile

Done.

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1315 (91cd4f0) into master (40134a0) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   91.44%   91.59%   +0.15%     
==========================================
  Files          98       98              
  Lines        5269     5273       +4     
==========================================
+ Hits         4818     4830      +12     
+ Misses        451      443       -8     
Impacted Files Coverage Δ
game/views/scoreboard.py 86.53% <100.00%> (+3.20%) ⬆️
game/random_road.py 91.00% <0.00%> (ø)
game/messages.py 97.72% <0.00%> (+0.23%) ⬆️

@faucomte97 faucomte97 merged commit c1cf628 into master Mar 8, 2022
@faucomte97 faucomte97 deleted the fix_student_scoreboard branch March 8, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants