fix: use a non threaded server in SeleniumTestCase #1325
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @razvan-pro)
rapid_router_test_settings.py, line 10 at r1 (raw file):
SELENIUM_WEBDRIVERS = { "default": {"callable": webdriver.Chrome, "args": (), "kwargs": {}}, "firefox": {"callable": webdriver.Firefox, "args": (), "kwargs": {}},
Is this part of the issue or just cleaning up? (out of interest)
game/end_to_end_tests/selenium_test_case.py, line 21 at r1 (raw file):
""" Replaces ThreadedWSGIServer with WSGIServer as the threaded one doesn't close the DB connections properly, thus triggering random "DB table locked" errors.
Does it mean the tests are gonna be slower?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dionizh)
rapid_router_test_settings.py, line 10 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Is this part of the issue or just cleaning up? (out of interest)
No, just spotted it and cleaning up 🙂
game/end_to_end_tests/selenium_test_case.py, line 21 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Does it mean the tests are gonna be slower?
Hm, I thought maybe, but they seem to be about the same time (actually faster somehow): 9m34s on this PR vs 9m52s on the previous one that passed 🙂
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
game/end_to_end_tests/selenium_test_case.py, line 21 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Hm, I thought maybe, but they seem to be about the same time (actually faster somehow): 9m34s on this PR vs 9m52s on the previous one that passed 🙂
Great!
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
- Coverage 91.59% 91.43% -0.17%
==========================================
Files 98 98
Lines 5261 5265 +4
==========================================
- Hits 4819 4814 -5
- Misses 442 451 +9
|
This change is